Ticket #116 (closed defect: fixed)

Opened 21 months ago

Last modified 18 months ago

make distclean cleans ChangeLog

Reported by: openid-provider.appspot.com/giraffedata Owned by: pbatard
Milestone: Component: libusb-1.0
Keywords: Cc:
Blocked By: Blocks:

Description

make distclean cleans (deletes) ChangeLog? - Makefile.am says "DISTCLEANFILES = ChangeLog? libusb-1.0.pc".

I don't know what the intent of that is, but 'make distclean' should return a tree to the same state as it is distributed, and ChangeLog? is distributed (at least it is in the 1.0.8 tarball).

Change History

comment:1 Changed 20 months ago by pbatard

  • Owner set to pbatard
  • Status changed from new to accepted

comment:2 Changed 20 months ago by pbatard

This has been fixed in the -stuge/testing staging git repository.

We may also want to add:

MAINTAINERCLEANFILES = ChangeLog?

in the main Makfile.am so that a 'make maintainer-clean' will balance the 'make ChangeLog?' issued by the maintainers. As per [1]: "If the maintainer built it (for instance, a .info file), then maintainer-clean should delete it."

[1] ​http://www.gnu.org/s/hello/manual/automake/Clean.html

comment:3 Changed 18 months ago by stuge

  • Resolution set to fixed
  • Status changed from accepted to closed

In [e1c06fb070c1328a3b78c7da8b9e779d466edd97/libusb]:

Makefile.am: Do not remove ChangeLog? on make distclean, fixes #116

[pbatard: Remove it on make maintainer-clean instead]

Note: See TracTickets for help on using tickets.